-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data management improvements #259
Conversation
fe06579
to
e4fd9bc
Compare
22072bb
to
67cd2db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 code quality is good, and changes would reduce reported errors, great work.
I would think having file operations for each websocket sync will increase performance loads significantly. have you thought about doing the backups only every X amount of syncs?
@grnd-alt Really valid points on server/files operations there, I thought about that too, the current implementation had some tweaks for that:
if (updatedData) {
await this.updateRoomWithData(room, updatedData, users, lastEditedUser)
this.createRoomBackup(room.id, room)
} => Would be better if can move it to a separate process (a queue processor) to process saving since it's not really critical
|
67cd2db
to
16ae3a5
Compare
@hweihwang Yes storing data in localstorage is a good idea, I think we should investigate it later on, as it might get complex to have divergent versions from multiple users, that need to be reconciled when restoring from the browser storage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 as said before the code is great.
IndexDB to be discussed later
Anything still pending for the merge? |
I'm still thinking a bit about the approach since the board can still work isolatedly without much needed from nextcloud server Not sure they're 100% related or might be in another ticket (Since users still need to aqquire jwt token from nextcloud server frequently but that's from FE => NC directly). Will think a bit more about that and will adjust the implementation at least to resolve some of. Want to know your thoughts on this @juliusknorr @grnd-alt too! Thank you! |
No description provided.